Upgrade version of dependencies + fix time breakages
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
force-pushed
the
brandur-upgrade-dependencies
branch
from
d37e4a4
to
fe5875a
Compare
To keep things somewhat current, upgrade all dependencies to latest versions. The hardest by far is `time`, which has broken its entire API surface area, _again_. We make some fairly substantial code changes to accommodate that. I also changed the store API to use `u64`s instead of `i64`s since they're working with nanoseconds. I realize in retrospect that this change might not be needed since Redis works with a signed integer type, but it improves the interface slightly in that a missing value is returned as a `None` instead of `-1`, which is more Rust-like.
brandur
force-pushed
the
brandur-upgrade-dependencies
branch
from
fe5875a
to
ff5c856
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep things somewhat current, upgrade all dependencies to latest
versions.
The hardest by far is
time, which has broken its entire API surfacearea, again. We make some fairly substantial code changes to
accommodate that.
I also changed the store API to use
u64s instead ofi64s sincethey're working with nanoseconds. I realize in retrospect that this
change might not be needed since Redis works with a signed integer type,
but it improves the interface slightly in that a missing value is
returned as a
Noneinstead of-1, which is more Rust-like.