Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

Updated for Scrapy v1.0 API changes #15

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

fraserharris
Copy link

  • works in production without raising deprecation warnings
  • Request Queue test fails, appears to be related to Scrapy v1 (?)

Test output: https://gist.github.com/fraserharris/df51b43184c8c35620cd

@jstoiko
Copy link
Member

jstoiko commented Sep 2, 2015

Thanks for the PR.

E       assert [] == [call('http://testdomain/pat...omain/path?wr=1&wa=1'), ...]
E         Right contains more items, first extra item: call('http://testdomain/path?wr=0')
E         Use -v to get the full diff

Same here. Don't have time to dig more though...

tonal added a commit to tonal/scrapy-webdriver that referenced this pull request Apr 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants