Configurable grafana ports #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redbaron
force-pushed
the
configurable-httpPort
branch
2 times, most recently
from
cc0620f
to
eb522d0
Compare
redbaron
force-pushed
the
configurable-httpPort
branch
from
eb522d0
to
4eb1ba5
Compare
brancz
reviewed
May 28, 2019
| @@ -137,6 +139,7 @@ local k = import 'ksonnet/ksonnet.beta.3/k.libsonnet'; | |||
| local c = | |||
| container.new('grafana', $._config.imageRepos.grafana + ':' + $._config.versions.grafana) + | |||
| (if std.length($._config.grafana.plugins) == 0 then {} else container.withEnv([env.new('GF_INSTALL_PLUGINS', std.join(',', $._config.grafana.plugins))])) + | |||
| container.withEnvMixin([env.new('GF_SERVER_HTTP_PORT', '' + $._config.grafana.containerPort.port)]) + | |||
There was a problem hiding this comment.
I think this can be done via the configuration file as well no? I think I'd prefer to keep all configuration possible within the config file. GF_INSTALL_PLUGINS is only there because it's the only way to configure plugins to install.
|
Just one comment, otherwise lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.