Small refactor to separate signal layout building #211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working adding "Opt" support (and "alt" support after that). In my work in progress I found I will need to create the concept of "nested block" where signals inside "Opt" element will make it grow accordingly.
In order to progress towards that I had to refactor the signal layout processing to make it run once for the whole diagram and another per each nested block (which holds its signals).
I wanted to create this PR to separate that refactor from the change so it is easier to follow the upcoming changes. If I detect other refactor/changes that I can separate to have smaller PRs then I'll do it (unless in case @bramp you'd rather like the whole change at once).
I could have refactored it further or cleaner, I guess we can decide that once "Opt" is supported and before starting with the "Alt" one.