Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent text from overlapping lines #202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MasonM
Copy link
Contributor

@MasonM MasonM commented Oct 25, 2018

This adds a white background to text strings so that they're easier to read when crossing a line.

Before:
screenshot_20181024_203643

After:
screenshot_20181024_203535

I didn't commit the dist/* file changes in order to make this easier to review. Let me know if I should and I'll push them up.

This adds a white background to text strings so that they're easier to read
when crossing a line.
@bramp
Copy link
Owner

bramp commented Oct 25, 2018

This is a very reasonable request, but I recall some reason why I didn't do this. Perhaps it interferes with CSS styling.

I will dig around to see if I recall, and get back to you.

@O-J1
Copy link

O-J1 commented Mar 9, 2019

@bramp Did you ever figure why:

but I recall some reason why I didn't do this. Perhaps it interferes with CSS styling.

Would be super handy 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants