Improved property value validation, minor changes

NotifyPropertyChangedBase/Helpers.cs

@@ -31,19 +31,5 @@ internal static bool GetIsValueType(this Type type)
  return type.IsValueType;
 #endif
  }
-
- internal static bool GetIsSubclassOf(this Type type, Type baseClass)
- {
-#if WINDOWS_UWP
- return type.GetTypeInfo().IsSubclassOf(baseClass);
-#else
- return type.IsSubclassOf(baseClass);
-#endif
- }
-
- internal static bool GetIsNullableOfT(this Type type)
- {
- return type.Name == "Nullable`1";
- }
  }
 }

NotifyPropertyChangedBase/NotifyPropertyChanged.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.ComponentModel;
-using System.Linq;
 #if WINDOWS_UWP
 using System.Reflection;
 #endif
@@ -266,18 +265,16 @@ private void ValidateValueForType(object value, Type type)
  {
  if (value == null)
  {
- if (type.GetIsValueType() && !type.GetIsNullableOfT())
+ if (type.GetIsValueType() && Nullable.GetUnderlyingType(type) == null)
  {
  throw new ArgumentException($"The type '{type}' is not a nullable type.");
  }
  }
  else
  {
- Type valueType = value.GetType();
-
- if (valueType != type && !valueType.GetIsSubclassOf(type) && !(type.GetIsNullableOfT() && type.GetGenericArguments().Contains(valueType)))
+ if (!type.IsAssignableFrom(value.GetType()))
  {
- throw new ArgumentException($"Value of type {valueType} cannot be assigned to a property of type ({type})");
+ throw new ArgumentException($"The specified value cannot be assigned to a property of type ({type})");
  }
  }
  }

README.md

@@ -2,7 +2,7 @@
 [![NuGet](https://img.shields.io/nuget/v/NotifyPropertyChangedBase.svg)](https://www.nuget.org/packages/NotifyPropertyChangedBase/)
 [![Build status](https://ci.appveyor.com/api/projects/status/jc9gcr4gldjr8nq6/branch/master?svg=true)](https://ci.appveyor.com/project/bramborman/notifypropertychangedbase/branch/master)
 [![Issues](https://img.shields.io/github/issues/bramborman/NotifyPropertyChangedBase.svg)](https://github.com/bramborman/NotifyPropertyChangedBase/issues)
-[![License](https://img.shields.io/badge/license-MIT-blue.svg)](LICENSE.md)
+[![License](https://img.shields.io/badge/license-MIT-blue.svg)](https://github.com/bramborman/NotifyPropertyChangedBase/blob/master/LICENSE.md)
 
 NotifyPropertyChangedBase provides you an easy to use base class `NotifyPropertyChanged` that helps you implement the `INotifyPropertyChanged` interface which can help you in many cases, whether are you developing WPF, Console, UWP or any other app.
 

appveyor.yml

@@ -5,7 +5,6 @@ branches:
  only:
  - master
  - dev
- - unit-tests-preparation
 skip_tags: true
 skip_commits:
  files: