Disallow issuing temp credential with another temp credential. #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not allow users to "wrap" a temporary credential with another temporary credential. This is fine from a security standpoint because such a credential will fail later while fetching API secrets. However, allowing this is a confusing and perhaps hard to debug behavior, so we prefer to fail fast.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ankrgyl
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not allow users to "wrap" a temporary credential with another temporary credential. This is fine from a security standpoint because such a credential will fail later while fetching API secrets. However, allowing this is a confusing and perhaps hard to debug behavior, so we prefer to fail fast.