Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix namespace in docblock #313

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix namespace in docblock #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## 6.7.1
* Fix wrong namespacing for the `Braintree\Result\ERror` class on docblocks
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Fix wrong namespacing for the `Braintree\Result\ERror` class on docblocks
* Fix wrong namespacing for the `Braintree\Result\Error` class on docblocks


## 6.7.0
* Fix lint errors on unit test

Expand Down
2 changes: 1 addition & 1 deletion lib/Braintree/PaymentMethodNonce.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class PaymentMethodNonce extends Base
*
* @see PaymentMethodNonceGateway::create()
*
* @return PaymentMethodNonce|Error
* @return PaymentMethodNonce|Result\Error
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make interface for those multiple different classes that are returned.

*/
public static function create($token, $params = [])
{
Expand Down
2 changes: 1 addition & 1 deletion lib/Braintree/PaymentMethodNonceGateway.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public function __construct($gateway)
* @param string $token the identifier of the payment method
* @param mixed|null $params additional parameters to be included in the request
*
* @return PaymentMethodNonce|Error
* @return PaymentMethodNonce|Result\Error
*/
public function create($token, $params = [])
{
Expand Down
4 changes: 2 additions & 2 deletions lib/Braintree/UsBankAccount.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public function isDefault()
*
* @see USBankAccountGateway::find()
*
* @return UsBankAccount|Error
* @return UsBankAccount|Result\Error
*/
public static function find($token)
{
Expand All @@ -91,7 +91,7 @@ public static function find($token)
* @param string $token the payment method identifier
* @param array $transactionAttribs all other transaction parameters
*
* @return UsBankAccount|Error
* @return UsBankAccount|Result\Error
*/
public static function sale($token, $transactionAttribs)
{
Expand Down