Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Venmo Demo UI #1437

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Cleanup Venmo Demo UI #1437

wants to merge 3 commits into from
+65 −74

Conversation

scannillo
Copy link
Contributor

@scannillo scannillo commented Oct 17, 2024 •
edited
Loading

Summary of changes

  • Create re-usable Toggle + Label UIView file
  • Remove 3 different Venmo buttons in favor of toggles for opt-in settings
    • This change is to prepare for another upcoming toggle to enable universal link returns from the Venmo app --> SDK (DTMOBILES-927)
  • Remove ECD options button & UI test (Android doesn't have them and I've never seen us use it)
Before After
Screenshot 2024-10-17 at 3 55 26 PM Screenshot 2024-10-17 at 4 56 44 PM

I am indeed a designer :D

Checklist

  • Added a changelog entry

Authors

@scannillo

@scannillo scannillo requested a review from a team as a code owner October 17, 2024 21:19
richherrera
richherrera approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@richherrera richherrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice design!! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richherrera richherrera richherrera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scannillo @richherrera