Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix url in the load_confounds template #134

Open
pbellec opened this issue Feb 15, 2021 · 1 comment
Open

fix url in the load_confounds template #134

pbellec opened this issue Feb 15, 2021 · 1 comment

Comments

@pbellec
Copy link

pbellec commented Feb 15, 2021

The regular expression to grab urls in the "project_url" field assumes that the URL is the last thing in that field.

This behaviour breaks the URL for the "denoising fMRI" project.

I am going to open a PR fixing this particular URL, may be worth considering getting a more robust parsing rule.

@SamGuay
Copy link
Member

SamGuay commented Feb 15, 2021

You are right, the regex implemented is the least robust of all time I'd say. It's done the job so far, but if anyway wants to fix it, they are welcome 😄.

I usually fix those problems behind the scene, but didn't catch your project. Sorrry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants