Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete old training data saves and warn user #365

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Delete old training data saves and warn user #365

merged 3 commits into from
Jan 18, 2024

Conversation

adamltyson
Copy link
Member

  • Deletes old training data when resaving to ensure that only the correct data is saved
  • Warns users about this
  • Tidies up the code base by using qtpy functions from brainglobe-utils

Closes #363

Requires brainglobe/brainglobe-utils#27 to be released and merged first

@adamltyson adamltyson mentioned this pull request Jan 16, 2024
Merged
@adamltyson adamltyson requested a review from a team January 17, 2024 13:37
IgorTatarnikov
IgorTatarnikov approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@IgorTatarnikov IgorTatarnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@IgorTatarnikov IgorTatarnikov merged commit ae10446 into main Jan 18, 2024
14 checks passed
@IgorTatarnikov IgorTatarnikov deleted the save-prompt branch January 18, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorTatarnikov IgorTatarnikov IgorTatarnikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Warn the user when overwriting training data in the curation interface
2 participants
@adamltyson @IgorTatarnikov