Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to brainreg v1 compliance #255

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Conversation

willGraham01
Copy link
Collaborator

@willGraham01 willGraham01 commented Nov 3, 2023

Updates cellfinder to be compliant with the upcoming release of brainreg version 1, as per brainglobe/brainreg#146.

Note that pyproject.toml now pins the brainreg version to be v1.0.0 to prevent users from installing an old version of brainreg through their cellfinder install.

Merge order

This needs to be merged after brainglobe/brainreg#146 and the new release of brainreg (version 1.0.0) is available on PyPI.

CI will fail until these conditions are met.

On merge

cellfinder will need a new release. This release version must be <v1.0.0.

@willGraham01 willGraham01 marked this pull request as ready for review November 6, 2023 09:45
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (21f724b) 23.31% compared to head (e17bb01) 23.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #255   +/-   ##
=======================================
  Coverage   23.31%   23.31%           
=======================================
  Files          22       22           
  Lines        1214     1214           
=======================================
  Hits          283      283           
  Misses        931      931           
Files Coverage Δ
cellfinder/main.py 0.00% <0.00%> (ø)
cellfinder/tools/prep.py 0.00% <0.00%> (ø)
cellfinder/tools/parser.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willGraham01 willGraham01 merged commit 0d517ed into main Nov 6, 2023
11 of 12 checks passed
@willGraham01 willGraham01 deleted the update-for-brainreg-v1 branch November 6, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants