Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose resetcam parameter #386

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Expose resetcam parameter #386

merged 2 commits into from
Sep 20, 2024

Conversation

IgorTatarnikov
Copy link
Member

Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Changing the zoom settings in the animation/video examples currently causes the camera to behave poorly.

What does this PR do?
Exposes the resetcam parameter in the Animation, and VideoMaker and sets it to False by default. If zoom is used resetcam can be set to True allowing the camera to behave appropriately.

References

closes #377
Please reference any existing issues/PRs that relate to this PR.

How has this PR been tested?

All current tests pass, the animation_callback.py, animation.py, and custom_camera.py all run as expected.
#360 runs correctly as well.

Is this a breaking change?

No.

Does this PR require an update to the documentation?

No.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.71%. Comparing base (551c079) to head (b03c650).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #386   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          27       27           
  Lines        1219     1219           
=======================================
  Hits         1057     1057           
  Misses        162      162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessandrofelder alessandrofelder merged commit 75ea81b into main Sep 20, 2024
13 checks passed
@alessandrofelder alessandrofelder deleted the reset-cam-animation branch September 20, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Zoom parameters aren't applying the correct scaling
2 participants