Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed?
Changing the zoom settings in the animation/video examples currently causes the camera to behave poorly.
What does this PR do?
Exposes the resetcam parameter in the
Animation
, andVideoMaker
and sets it toFalse
by default. If zoom is usedresetcam
can be set toTrue
allowing the camera to behave appropriately.References
closes #377
Please reference any existing issues/PRs that relate to this PR.
How has this PR been tested?
All current tests pass, the
animation_callback.py
,animation.py
, andcustom_camera.py
all run as expected.#360 runs correctly as well.
Is this a breaking change?
No.
Does this PR require an update to the documentation?
No.
Checklist: