Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark tests that are expected to fail with xfail rather than just not running them #367

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

adamltyson
Copy link
Member

At least this way we will know whether or not they are passing.

@adamltyson adamltyson requested a review from IgorTatarnikov June 7, 2024 09:54
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.22%. Comparing base (f1e3785) to head (303474f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
+ Coverage   87.31%   88.22%   +0.90%     
==========================================
  Files          27       27              
  Lines        1214     1214              
==========================================
+ Hits         1060     1071      +11     
+ Misses        154      143      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@IgorTatarnikov IgorTatarnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@IgorTatarnikov IgorTatarnikov merged commit 767f5d1 into main Jun 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants