Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported Python versions #363

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Update supported Python versions #363

merged 2 commits into from
Jun 7, 2024

Conversation

adamltyson
Copy link
Member

No description provided.

@adamltyson adamltyson requested a review from a team June 5, 2024 14:58
@adamltyson
Copy link
Member Author

Tests seem to be failing for the usual neuromorpho issue. Should we think about disabling the tests for this, or just removing the features that rely on it totally?

@alessandrofelder
Copy link
Member

Hopefully #366 will help here - is that ready for review yet @IgorTatarnikov ?

@IgorTatarnikov
Copy link
Member

It's ready, I had to fiddle with the screenshot example. It seems that when we run the example scripts during testing they pollute the global settings so the background was set to [0.22, 0.22, 0.22] if the full test suite was run first causing the screenshot similarity index to be low.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.98%. Comparing base (767f5d1) to head (fac475c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #363   +/-   ##
=======================================
  Coverage   86.98%   86.98%           
=======================================
  Files          27       27           
  Lines        1214     1214           
=======================================
  Hits         1056     1056           
  Misses        158      158           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamltyson
Copy link
Member Author

Tests finally pass 🎉

@IgorTatarnikov IgorTatarnikov merged commit 570cecd into main Jun 7, 2024
13 checks passed
@IgorTatarnikov IgorTatarnikov deleted the python-versions branch June 7, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants