User-specified colormap in PointsDensity #325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
NA
What does this PR do?
Allows the user to specify a colormap for the points density feature.
References
#323
How has this PR been tested?
I ran examples/cell_density.py example,
brainrender/examples/cell_density.py
Line 42 in 980a76f
using
scene.add(PointsDensity(coordinates, colors="inferno"))
instead.Is this a breaking change?
I hope not
Does this PR require an update to the documentation?
The PointsDensity is not documented in the documentation, so NA. We could add the colormap option in the example.
Checklist:
Notes
I'm unfamiliar with (read : I don't know anything about) tests and pre-commits, so I didn't do those. I used ruff to format my addition in VSCode, but that's about it.