-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update brainglobe-napari-io import #172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Given that the new brainglobe-napari-io
is released, should we pin the version in this PR (and then merge and release)?
@alessandrofelder sorry for the dismissal I was only following your recommendation 😂 But have now pinned the new version in this update. In cases like this where we have tool updates that are dependent on releases, I think it's important we always pin new versions in the pull requests. The meta-package should handle them, but giving it some help wouldn't go amiss :L |
The metapackage (at least its user-facing part, not the future benchmarks that will depend on the dev version) will only install released versions, right. So should this technically be
? |
Pinning (the minimum) version is always probably a good idea though right, so that |
Yeah sorry for the unhelpful comment - this is what I meant 😅 In this case,
|
Requires brainglobe/brainglobe-napari-io#61 to be merged (tests will fail until it's released), and when a new version is released, it will need to pin the latest version of
brainglobe-napari-io
.