Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 updates for brainreg changes #79

Merged
merged 13 commits into from
Nov 6, 2023
Merged

V1 updates for brainreg changes #79

merged 13 commits into from
Nov 6, 2023

Conversation

willGraham01
Copy link
Contributor

@willGraham01 willGraham01 commented Oct 27, 2023

Closes brainglobe/BrainGlobe#39

Logs the changes that are being made to the brainreg, brainreg-napari, and brainreg-segment packages to the website.

Also starts on the brainglobe version 1 changelog page.

These pages are currently not linked to from anywhere on the website, although they are none-the-less accessible.

@adamltyson
Copy link
Member

Thanks @willGraham01. I think this should go in somwhere other than documentation. documentation has so far contained mostly reference guides to using the s/w. Maybe we should create a development section, and also move the dev guides. Any ideas @alessandrofelder?

@willGraham01
Copy link
Contributor Author

Maybe we should create a development section

We do already have a developers folder (and presumably page) so maybe it should go there? Although we probably want a front-facing "version 1 is coming" page too

@alessandrofelder
Copy link
Member

Yea maybe we need a "Releases" section for changelogs? And a "Blogs" session somewhere close to the front for announcements such as this, that links to the relevant changelog?

@alessandrofelder
Copy link
Member

I think this is separate from the general developer docs - it's an announcement that we mostly need users and developers of other packages (also a kind of user I guess) to be aware of?

@adamltyson
Copy link
Member

adamltyson commented Oct 27, 2023

We do already have a developers folder (and presumably page) so maybe it should go there?

We have a developers folder, but it's (currently) linked within documentation, so we should probably make that accessible somewhere else.

Yea maybe we need a "Releases" section for changelogs?

Ideally

And a "Blogs" session somewhere close to the front for announcements such as this, that links to the relevant changelog?

Yup, pydata-sphinx has a blogging extension we can use (we use it for https://neuroinformatics.dev/)

I think this is separate from the general developer docs - it's an announcement that we mostly need users and developers of other packages (also a kind of user I guess) to be aware of?

I think the blog can announce to everyone, and then this can link to specific docs for developers and/or users

FYI rather than changing the home page, we can add an announcement that links to the blog.

@willGraham01
Copy link
Contributor Author

So end-goal would be a structure like the following (within docs/source):

blogs/
  version_1_announcement.md                      # Main "this is happening" announcement
  brainreg_updated_to_version_1_annoucement.md   # Added as incremental packages are updated
  cellfinder_updated_to_version_1_annoucement.md # etc
  brainglobe_vesion_1_released.md                # :partying_face: 

index.md        # Gets an announcement directing to version_1_annoucement.md

releases/
  v1/
    full_changelog.md          # High level overview, TL;DR style
    brainreg.md                # Detailed listing of what has changed name, 
    cellfinder.md              # where functionality has been moved to, etc, on a
                               # package-by-package basis
documentation/
  # Individual pages to be updated to version 1 compatible information as appropriate.

On my to-do list today / Tuesday is the Blog announcement so I can start a separate PR for that, then rebase this on top.

@adamltyson
Copy link
Member

So end-goal would be a structure like the following (within docs/source):

blogs/
  version_1_announcement.md                      # Main "this is happening" announcement
  brainreg_updated_to_version_1_annoucement.md   # Added as incremental packages are updated
  cellfinder_updated_to_version_1_annoucement.md # etc
  brainglobe_vesion_1_released.md                # :partying_face: 

index.md        # Gets an announcement directing to version_1_annoucement.md

releases/
  v1/
    full_changelog.md          # High level overview, TL;DR style
    brainreg.md                # Detailed listing of what has changed name, 
    cellfinder.md              # where functionality has been moved to, etc, on a
                               # package-by-package basis
documentation/
  # Individual pages to be updated to version 1 compatible information as appropriate.

On my to-do list today / Tuesday is the Blog announcement so I can start a separate PR for that, then rebase this on top.

100% thanks!

docs/source/index.md Outdated Show resolved Hide resolved
@adamltyson
Copy link
Member

Sorry @willGraham01 I didn't fully understand the structure you outlined earlier. I don't think releases should be in the top bar or in a card. I think it's just not important enough for most users for it to be presented so prominently.

As suggested by @niksirbi, what about a "community" section to bring some different parts together? I'll update this PR and you can take a look.

As an aside, can the blog list posts in reverse chronological order instead?

@willGraham01
Copy link
Contributor Author

what about a "community" section to bring some different parts together? I'll update this PR and you can take a look.

No problem, shout when you've pushed things up. (I've just removed the releases card on the main page).

As an aside, can the blog list posts in reverse chronological order instead?

I assume so, I also thought that was the default. Let me investigate

@adamltyson
Copy link
Member

I've added a new community section (where I will also eventually add the roadmap). Some of the sections there aren't as prominent as I would like, but I think we have to prioritise and make sure a small amount of the most useful information is presented first.

Deletion of tutorial file is correct - changes to dir structure already incorporated.
@willGraham01 willGraham01 marked this pull request as ready for review November 6, 2023 10:11
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @willGraham01 and @adamltyson . Looks good and ready for the big merge!

@alessandrofelder alessandrofelder merged commit a36a375 into main Nov 6, 2023
@alessandrofelder alessandrofelder deleted the brainreg-update branch November 6, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BGV1] Updates to documentation in in light of brainreg updates
3 participants