Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable link check #194

Merged
merged 1 commit into from
May 29, 2024
Merged

Disable link check #194

merged 1 commit into from
May 29, 2024

Conversation

adamltyson
Copy link
Member

This is getting annoying, as it often prevents the docs from building. I assume it's due to something stopping bots, but 🤷. We can (should) still run this locally, and maybe renable it in the future.

@adamltyson adamltyson requested a review from a team May 29, 2024 14:03
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a checkbox to the PR template for this repo to remind us to check links locally?

@adamltyson
Copy link
Member Author

I think we only have a template for the whole org, adding it may get confusing for new contributors? We could add it to the docs.

@alessandrofelder
Copy link
Member

alessandrofelder commented May 29, 2024

I don't think it would be a big problem to have a tailored PR template for the docs repo?
E.g. the question we ask "Does this require an update to the documentation" in the central PR template is not very sensible for the docs repo?
We shouldn't add this to the org-level template if that's what you mean.

@alessandrofelder
Copy link
Member

Probably a different ticket though (#195 ). Merging

@alessandrofelder alessandrofelder merged commit 96f2118 into main May 29, 2024
3 checks passed
@alessandrofelder alessandrofelder deleted the no-link-check branch May 29, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants