Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cellfinder-core and cellfinder-napari merge update #104

Merged
merged 17 commits into from
Jan 3, 2024

Conversation

willGraham01
Copy link
Contributor

@willGraham01 willGraham01 commented Nov 28, 2023

See brainglobe/BrainGlobe#46

Updates the website with blog posts, changelog, and user docs for the cellfinder core and napari plugins merging.

  • The November roadmap now has outdated information and links, but this is deliberately left like this since it's a reflection of the state of BrainGlobe at that time
  • Blog post added
  • Changelog added
  • Install recommendations updated

@willGraham01 willGraham01 marked this pull request as ready for review December 19, 2023 11:43
@willGraham01 willGraham01 requested a review from a team December 19, 2023 11:54
Copy link
Member

@adamltyson adamltyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @willGraham01. I'm ok for it to be merged as-is, but I've raised #129 because I think the current status of the cli being included within the cellfinder section is confusing. This will be more confusing when we rename the CLI (which I think we should do soon).

docs/source/blog/version1/core_and_napari_merge.md Outdated Show resolved Hide resolved
docs/source/documentation/cellfinder/index.md Outdated Show resolved Hide resolved
docs/source/documentation/cellfinder/index.md Outdated Show resolved Hide resolved
docs/source/documentation/cellfinder/installation.md Outdated Show resolved Hide resolved
@willGraham01
Copy link
Contributor Author

@adamltyson I've attempted to disentangle the cellfinder package docs from the now-new brainmapper docs - mostly involves a lot of moving things around and updating some names, but you might want to double check:

  • The brainmapper tutorial
  • The brainmapper documentation
  • The remaining cellfinder information

Copy link
Member

@adamltyson adamltyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling the cellfinder->brainmapper issue @willGraham01, I wasn't looking forward to doing it myself!

I've left a few comments. TBH I think this naming migration will drag on for a while as we keep finding outdated references. Feel free to raise issues rather than tackle everything!

docs/source/tutorials/cellfinder-cli/index.md Outdated Show resolved Hide resolved
docs/source/tutorials/cellfinder-cli/index.md Outdated Show resolved Hide resolved
docs/source/tutorials/cellfinder-cli/index.md Outdated Show resolved Hide resolved
docs/source/documentation/cellfinder/index.md Outdated Show resolved Hide resolved
@willGraham01 willGraham01 force-pushed the cellfinder-merge branch 3 times, most recently from d8bacb2 to b4e73d6 Compare January 2, 2024 12:40
@willGraham01 willGraham01 merged commit b95451f into main Jan 3, 2024
2 checks passed
@willGraham01 willGraham01 deleted the cellfinder-merge branch January 3, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants