update to new cellfinder function names #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandrofelder
force-pushed
the
update-to-cellfinder-renaming
branch
from
fc209af to
0b3938b
Compare
|
Superceded by #89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
We've updated some function names as part of brainglobe/cellfinder#394
What does this PR do?
Updates the function names.
When this is merged, I think we should
References
brainglobe/cellfinder#394 and brainglobe/cellfinder#393
How has this PR been tested?
Locally, which current main of
cellfinderinstalled.Is this a breaking change?
Yes, this will now require cellfinder >=1.1.2
Does this PR require an update to the documentation?
No.
Checklist: