Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code and refactor #79

Merged
merged 3 commits into from
Jan 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,49 +20,17 @@
cell_list.append([cell.z, cell.y, cell.x])
cells = np.array(cell_list)

run_analysis(
logging.info("Transforming points to atlas space")
transformed_cells, points_out_of_bounds = transform_points_to_atlas_space(

Check warning on line 24 in brainglobe_workflows/brainmapper/analyse.py

View check run for this annotation

Codecov / codecov/patch

brainglobe_workflows/brainmapper/analyse.py#L23-L24

Added lines #L23 - L24 were not covered by tests
cells,
args.signal_planes_paths[0],
args.orientation,
args.voxel_sizes,
atlas,
deformation_field_paths,
downsampled_space,
args.paths.downsampled_points,
args.paths.atlas_points,
args.paths.brainrender_points,
args.brainreg_paths.volume_csv_path,
args.paths.all_points_csv,
args.paths.summary_csv,
)


def run_analysis(
cells,
signal_planes,
orientation,
voxel_sizes,
atlas,
deformation_field_paths,
downsampled_space,
downsampled_points_path,
atlas_points_path,
brainrender_points_path,
volume_csv_path,
all_points_csv_path,
summary_csv_path,
):
logging.info("Transforming points to atlas space")
transformed_cells, points_out_of_bounds = transform_points_to_atlas_space(
cells,
signal_planes,
orientation,
voxel_sizes,
downsampled_space,
atlas,
deformation_field_paths,
downsampled_points_path=downsampled_points_path,
atlas_points_path=atlas_points_path,
downsampled_points_path=args.paths.downsampled_points,
atlas_points_path=args.paths.atlas_points,
)
logging.warning(
f"{len(points_out_of_bounds)} points ignored due to falling outside "
Expand All @@ -75,11 +43,11 @@
cells,
transformed_cells,
atlas,
volume_csv_path,
all_points_csv_path,
summary_csv_path,
args.brainreg_paths.volume_csv_path,
args.paths.all_points_csv,
args.paths.summary_csv,
)
logging.info("Exporting data to brainrender")
export_points_to_brainrender(
transformed_cells, atlas.resolution[0], brainrender_points_path
transformed_cells, atlas.resolution[0], args.paths.brainrender_points
)
Empty file.
Loading