-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hard dependency on brainglobe-meta package #72
Conversation
Shall we remove these? it seems weird to have some specific packages pinned and not others. We have to keep the metapackage dependencies up to date anyway, so we may as well fully rely on that. |
Up to you and how much faith you have in the metapackage 😅 I ran this by @alessandrofelder briefly last week and we came to the same conclusion - let's just depend on the metapackage and be vigilant, as it's better to test from a user-style install than a developer one. Although @sfmig might want to preserve the explicit dependencies in her ASV benchmark dependencies? Theoretically though the metapackage will handle that too... |
Should the benchmarks at some point mainly run on the development versions of the tools, to warn developers about problems before we release? |
Ideally yeah, though there's no nice way to get |
Cool, let's make that a separate issue to this :) |
5d73fe6
to
3b664b0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage 81.43% 81.43%
=======================================
Files 29 29
Lines 1573 1573
=======================================
Hits 1281 1281
Misses 292 292 ☔ View full report in Codecov by Sentry. |
Merging this so we can release. |
See brainglobe/BrainGlobe#33 | This should be the final task in the list, so it actually closes brainglobe/BrainGlobe#33 😱
As per the version 1 release plan, this repository should depend on the meta-package rather than the individual tooling packages themselves.
As such, have added
brainglobe>=1.0.0
to the top of the dependency list.Have left in the explicit
brainreg>=1.0.0
andcellfinder>=1.0.0
dependencies, even though these (or the most recent versions) should be fetched by the meta-package anyway.This just ensures that the minimum version of the meta-package that will be fetched must be one that adheres to our BrainGlobe version 1 update: IE fetching the new cellfinder package and brainreg plugins.
Depends on:
brainglobe-meta
version 1.CI will fail until all of the above are met.