Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transfer back from brainglobe-scripts #14

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Sep 15, 2023

decided to keep everything here instead of in brainglobe-scripts brainglobe-scripts is now obsolete.

this is a 1:1 copy of what @sfmig and I had done in brainglobe-scripts/main, with the package renamed to brainglobe-workflows

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@9ba4e22). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 8665e74 differs from pull request most recent head 00b39f0. Consider uploading reports for the commit 00b39f0 to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##             main     #14   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?       1           
  Lines           ?       5           
  Branches        ?       0           
======================================
  Hits            ?       0           
  Misses          ?       5           
  Partials        ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@adamltyson adamltyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but there are a lot of references to brainglobe-scripts in pyproject.toml. Also, is this going to mess up #1?

decided to keep everything here instead of in `brainglobe-scripts`
`brainglobe-scripts` is now obsolete.
@sfmig sfmig merged commit fa48258 into main Sep 18, 2023
18 checks passed
@sfmig sfmig deleted the transfer-from-bg-scripts branch September 18, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants