Add brainglobe-atlasapi to latest-github-requirements
#120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
==========================================
+ Coverage 85.71% 85.83% +0.11%
==========================================
Files 17 17
Lines 847 847
==========================================
+ Hits 726 727 +1
+ Misses 121 120 -1 ☔ View full report in Codecov by Sentry. |
alessandrofelder
requested changes
Jun 17, 2024
There was a problem hiding this comment.
Looks good - thank you @sfmig
While we're here, could you
- add
morphapias a developer dependency too - remove
cellfinderas a dependency (cellfinder[napari]is the same plus optionalnaparistuff)?
Then this would match the dependency tree for BrainGlobe repos.
alessandrofelder
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
The current
latest-github-requirements.txtlist includes all the dependencies of thebrainglobe-metapackage, except forbrainglobe-atlasapi. I am not sure why we didn't include that one, but I noticedbrainrenderdepends on it.So as it is now,
brainrenderwill be installed using thelatest-githubversion, butbrainglobe-atlasapiwill remain in the pip version.We can verify this by checking the logs of this run which used
latest-githubdependencies. Al brainglobe dependencies are indeed from github except for brainglobe-atlasapi.What does this PR do?
It adds brainglobe-atlasapi to the latest-github requirements file.
References
Please reference any existing issues/PRs that relate to this PR.
How has this PR been tested?
\
Is this a breaking change?
\
Does this PR require an update to the documentation?
\
Checklist: