Slim dependencies #119
Merged
Slim dependencies #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfmig
force-pushed
the
smg/slim-dependencies
branch
from
50f51f6 to
ca0f749
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
=======================================
Coverage 85.83% 85.83%
=======================================
Files 17 17
Lines 847 847
=======================================
Hits 727 727
Misses 120 120 ☔ View full report in Codecov by Sentry. |
|
Imio can also be removed (it's been merged into brainglobe-utils). |
alessandrofelder
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
It seems like we have redundant dependencies in
pyproject.tomlbut would like to double check.What does this PR do?
Remove dependencies that are included in brainglobe meta package.
References
Inspired by brainglobe/brainglobe-atlasapi#310
How has this PR been tested?
Tests pass locally and on CI.
Is this a breaking change?
No.
Does this PR require an update to the documentation?
No.
Checklist: