Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define two asv configurations for pip and latest-github dependencies #110

Merged
merged 20 commits into from
May 31, 2024

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented May 20, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
We want to be able to run benchmarks using two different sets of dependencies.

What does this PR do?

  • We add two asv config files for these two sets of dependencies
  • We adapt the CI benchmark check (which imports and checks basic validity of the benchmarks) to run both cases.
  • We updated the benchmarks README

References

#75

How has this PR been tested?

We checked the benchmarks run locally.
Tests pass locally and in CI.
asv check passes in CI

Is this a breaking change?

No.

Does this PR require an update to the documentation?

We updated the benchmarks README.

Checklist:

  • The code has been tested locally
  • [ n\a ] Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder self-assigned this May 20, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.83%. Comparing base (4b08e30) to head (8cb1b3f).
Report is 4 commits behind head on main.

Current head 8cb1b3f differs from pull request most recent head 6712500

Please upload reports for the commit 6712500 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   85.68%   85.83%   +0.15%     
==========================================
  Files          16       17       +1     
  Lines         838      847       +9     
==========================================
+ Hits          718      727       +9     
  Misses        120      120              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig sfmig changed the title prototype dependency install from github Define two asv configurations for pip and latest-github dependencies May 31, 2024
@sfmig sfmig marked this pull request as ready for review May 31, 2024 15:04
Copy link
Member

@IgorTatarnikov IgorTatarnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested by running locally with the default dataset.

@alessandrofelder alessandrofelder merged commit 86c292c into main May 31, 2024
8 checks passed
@alessandrofelder alessandrofelder deleted the run-asv-on-dev-dependencies branch May 31, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants