-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define two asv configurations for pip and latest-github dependencies #110
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 85.68% 85.83% +0.15%
==========================================
Files 16 17 +1
Lines 838 847 +9
==========================================
+ Hits 718 727 +9
Misses 120 120 ☔ View full report in Codecov by Sentry. |
This reverts commit 3f067d5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tested by running locally with the default dataset.
Description
What is this PR
Why is this PR needed?
We want to be able to run benchmarks using two different sets of dependencies.
What does this PR do?
References
#75
How has this PR been tested?
We checked the benchmarks run locally.
Tests pass locally and in CI.
asv check passes in CI
Is this a breaking change?
No.
Does this PR require an update to the documentation?
We updated the benchmarks README.
Checklist: