Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conform to new linting rules #97

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conform to new linting rules #97

merged 1 commit into from
Aug 7, 2024

Conversation

IgorTatarnikov
Copy link
Member

Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Linting is failing in #96 due to instance checks being flagged as an error now.

What does this PR do?
Fixes the linting error.

References

How has this PR been tested?

Linting passes with the new ruff version, all tests pass, and visual inspection confirms the function still returns the correct subset of layer types.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@IgorTatarnikov IgorTatarnikov requested a review from a team August 7, 2024 10:16
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.72%. Comparing base (6044656) to head (e7d448b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   92.72%   92.72%           
=======================================
  Files          37       37           
  Lines        1855     1855           
=======================================
  Hits         1720     1720           
  Misses        135      135           
Flag Coverage Δ
numba 92.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessandrofelder alessandrofelder merged commit c34b39a into main Aug 7, 2024
14 checks passed
@alessandrofelder alessandrofelder deleted the pre-commit-fix branch August 7, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants