Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nrrd IO #82

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Remove nrrd IO #82

merged 1 commit into from
Jun 6, 2024

Conversation

adamltyson
Copy link
Member

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
pynrrd seems to be causing a few issues with newer versions of Python (t doesn't seem to have been updated for 2 years). Mostly because it uses nptyping, which itself needs updating.

However, I don't think we need nrrd IO functionality in brainglobe, because we only deal with tiffs and nii. We may use this functionality in the atlas generation code, but I think if we do, it should be a specific requirement for that script (and not for the whole of brainglobe as it is at the moment).

Keen to know if this is going to break anything, but I don't think it should.

What does this PR do?
Removes all nrrd IO code. It also removes (what I think is) some outdated error/warning handling.

References

N/A

How has this PR been tested?

Removed nrrd tests, and ran other tests as normal.

Is this a breaking change?

I don't think so.

Does this PR require an update to the documentation?

Yes, the reference to nrrd IO needs to be removed from the website docs.

Checklist:

  • The code has been tested locally
  • [] Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@adamltyson adamltyson requested a review from a team June 5, 2024 16:36
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.43%. Comparing base (6185777) to head (38c21ac).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   90.53%   90.43%   -0.11%     
==========================================
  Files          35       35              
  Lines        1427     1411      -16     
==========================================
- Hits         1292     1276      -16     
  Misses        135      135              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy to approve this - the changes look reasonable. A double-check of our org suggests that it wouldn't break anything (apart from maybe some atlas generation parts, as implied in the PR summary.

@alessandrofelder alessandrofelder merged commit ee80c66 into main Jun 6, 2024
13 checks passed
@alessandrofelder alessandrofelder deleted the pynrrd branch June 6, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants