Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed collapsed icon for CollapsibleWidget #78

Merged
merged 2 commits into from
May 24, 2024

Conversation

IgorTatarnikov
Copy link
Member

Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
The current collapsed icon is currently ▲.

What does this PR do?
Changes the default collapsed icon to ▶ and exposes it as an optional parameter.

How has this PR been tested?

Tested locally.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.

Checklist:

  • The code has been tested locally
  • The code has been formatted with pre-commit

@IgorTatarnikov IgorTatarnikov requested a review from a team May 24, 2024 14:19
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.53%. Comparing base (3465b1f) to head (ec81b8f).
Report is 85 commits behind head on main.

Current head ec81b8f differs from pull request most recent head a7b7c73

Please upload reports for the commit a7b7c73 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #78       +/-   ##
===========================================
+ Coverage   64.04%   90.53%   +26.49%     
===========================================
  Files          33       35        +2     
  Lines         840     1427      +587     
===========================================
+ Hits          538     1292      +754     
+ Misses        302      135      -167     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessandrofelder alessandrofelder merged commit 6a2f73c into main May 24, 2024
21 checks passed
@alessandrofelder alessandrofelder deleted the change-collapsed-icon branch May 24, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants