Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be permissive about tiff axis metadata #75

Merged
merged 2 commits into from
May 15, 2024

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented May 15, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

Current code loading tiff z stacks into memory throws an error, but...

What does this PR do?

Follow-up to #73
Modifies read_z_stack to write debug logs instead of throwing an error, if a tiff stack with no axis metadata is read.
Adds tests that check that debug log is called in these cases.

References

PR discussion linked above

How has this PR been tested?

New tests added.

Is this a breaking change?

No.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • [n/a] The documentation has been updated to reflect any changes.
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder marked this pull request as ready for review May 15, 2024 12:56
@alessandrofelder alessandrofelder requested a review from a team May 15, 2024 12:56
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.53%. Comparing base (a1a53b5) to head (fcf878b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   89.76%   90.53%   +0.77%     
==========================================
  Files          35       35              
  Lines        1427     1427              
==========================================
+ Hits         1281     1292      +11     
+ Misses        146      135      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamltyson adamltyson merged commit f7bd231 into main May 15, 2024
13 checks passed
@adamltyson adamltyson deleted the permissive-tiff-stack-loading branch May 15, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants