Add tests for qtpy sub-module #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 86.49% 89.15% +2.65%
==========================================
Files 35 35
Lines 1355 1355
==========================================
+ Hits 1172 1208 +36
+ Misses 183 147 -36 ☔ View full report in Codecov by Sentry. |
alessandrofelder
approved these changes
Apr 5, 2024
|
|
||
| def test_add_int_box(qtbot, box): | ||
| """ | ||
| Smoke tests for add_float_box for all conditional branches |
There was a problem hiding this comment.
Suggested change
| Smoke tests for add_float_box for all conditional branches | |
| Smoke tests for add_int_box for all conditional branches |
Could you clarify what "all conditional branches" means in each of the tests in this file by updating the docstrings?
There was a problem hiding this comment.
I updated the docstrings to make it clearer what each of these tests do. Feel free to merge if you're happy with it!
alessandrofelder
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
The coverage of the qtpy sub-module is currently only 73%
What does this PR do?
Increases test coverage on the qtpy sub-module to >90%. Also expands some type hints / docstrings so functions are consistent with each other.
References
Closes #63
How has this PR been tested?
All tests pass locally.
Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: