-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for cells sub-module #61
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
+ Coverage 84.07% 86.56% +2.49%
==========================================
Files 35 35
Lines 1331 1355 +24
==========================================
+ Hits 1119 1173 +54
+ Misses 212 182 -30 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good ✨
Some tiny comments - a lot of them are different instances of the same suggestion!
Co-authored-by: Alessandro Felder <[email protected]>
for more information, see https://pre-commit.ci
Thanks @alessandrofelder ! I've added all of your suggestions now - feel free to merge if you're happy with it. |
Description
What is this PR
Why is this PR needed?
The coverage of the cells sub-module is currently only 70%, and there are very few docstrings explaining its functionality.
What does this PR do?
This PR expands the tests and docstrings, bringing the cells sub-module coverage up to 90%.
References
Closes #57
Adds docstrings for #19
How has this PR been tested?
Tests have been updated, and all pass locally.
Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: