Use data path and fixtures consistently #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
Currently tests don't access the test data directory in a consistent way. For example, many use
os.path.join("tests", "data")
which meanspytest
fails when run from any location apart from the top directory.Also, fixtures aren't consistently used for data generated inside of test modules.
What does this PR do?
This PR creates a
data_path
fixture inside oftests/tests/conftest.py
that can be re-used by all tests. This ensurespytest
can be run from any location successfully.The PR also makes sure that any data generated inside of tests is wrapped into a fixture.
References
None
How has this PR been tested?
All tests pass locally.
Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: