Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use codecov token in test_and_deploy #55

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

K-Meech
Copy link
Contributor

@K-Meech K-Meech commented Mar 18, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Codecov is still failing with Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1

What does this PR do?
This PR ensures test_and_deploy is using the codecov token, as recommended in the readme for the neuroinformatics unit test action

References

For #41

How has this PR been tested?

Hopefully codecov won't error on the github actions runs for this PR

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@K-Meech K-Meech requested a review from a team March 18, 2024 16:00
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.07%. Comparing base (13d0444) to head (3045715).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   74.55%   84.07%   +9.51%     
==========================================
  Files          25       35      +10     
  Lines         849     1331     +482     
==========================================
+ Hits          633     1119     +486     
+ Misses        216      212       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@K-Meech
Copy link
Contributor Author

K-Meech commented Mar 18, 2024

Can confirm that Codecov seems to be working correctly now - errors have disappeared on the run for this PR

@alessandrofelder alessandrofelder merged commit 87ca009 into main Mar 18, 2024
12 checks passed
@alessandrofelder alessandrofelder deleted the codecov_token branch March 18, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants