Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit n processes on Windows to 61 #5

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Limit n processes on Windows to 61 #5

merged 4 commits into from
Oct 13, 2023

Conversation

adamltyson
Copy link
Member

@adamltyson adamltyson commented Oct 13, 2023

Closes #6

Slightly refactors to make it easy to test this addition.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (b7209ef) 60.78% compared to head (4154739) 61.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
+ Coverage   60.78%   61.23%   +0.44%     
==========================================
  Files          31       31              
  Lines         765      779      +14     
==========================================
+ Hits          465      477      +12     
- Misses        300      302       +2     
Files Coverage Δ
brainglobe_utils/general/system.py 62.00% <72.72%> (+2.44%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamltyson adamltyson requested a review from a team October 13, 2023 14:20
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@alessandrofelder alessandrofelder merged commit a704b8c into main Oct 13, 2023
20 checks passed
@alessandrofelder alessandrofelder deleted the max-processes branch October 13, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number of workers for concurrent futures must be <=61 on Windows
2 participants