Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use log10 for zero padding tiffs #104

Merged
merged 2 commits into from
Nov 1, 2024
Merged

use log10 for zero padding tiffs #104

merged 2 commits into from
Nov 1, 2024

Conversation

alessandrofelder
Copy link
Member

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Zero-padding width in filenames when saving to tiffs was wrongly calculated.

What does this PR do?
Fixes the zero-padding width, and tests it's calculated correctly.

How has this PR been tested?

New test added.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • [n/a] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.73%. Comparing base (3a909b4) to head (7101ed1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   92.73%   92.73%           
=======================================
  Files          37       37           
  Lines        1857     1857           
=======================================
  Hits         1722     1722           
  Misses        135      135           
Flag Coverage Δ
numba 92.67% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@IgorTatarnikov IgorTatarnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@IgorTatarnikov IgorTatarnikov merged commit cee4a44 into main Nov 1, 2024
14 checks passed
@IgorTatarnikov IgorTatarnikov deleted the padding_bug branch November 1, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants