Standardise package structure and add tests #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
for more information, see https://pre-commit.ci
|
|
||
| def test_xml_write_no_metadata(tmp_path): | ||
| xml_path = str(tmp_path / "points.xml") | ||
| rng = np.random.default_rng() |
Check notice
Code scanning / SonarCloud
Results that depend on random number generation should be reproducible Low test
alessandrofelder
approved these changes
Dec 20, 2023
Co-authored-by: Alessandro Felder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
This package followed the napari cookiecutter, not the neuroinformatics one (as with the rest of BrainGlobe). While standardisation with the rest of the napari plugin ecosystem was good, I thought it was much more likely that NIU members will maintain this plugin rather than members of the wider napari ecosystem.
There was also a lack of tests (#7)
What does this PR do?
Restructures the package and updates the tooling to match the rest of the repos and adds some more tests.
References
Closes #7
How has this PR been tested?
Tests added
Is this a breaking change?
Nope
Does this PR require an update to the documentation?
Nope
Checklist: