Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make embed color optional #961

Merged
merged 2 commits into from
Oct 20, 2023
Merged

fix: make embed color optional #961

merged 2 commits into from
Oct 20, 2023

Conversation

erics118
Copy link
Contributor

@erics118 erics118 commented Oct 20, 2023

made embed::color a std::optional
Discord does not use 0x000000 as the default embed color, so this actually does result in a visual change to the embeds created that dont have a color, (also has a more noticable change in light mode)

Before:
CleanShot 2023-10-20 at 17 05 12CleanShot 2023-10-20 at 17 05 04
After:
CleanShot 2023-10-20 at 17 05 21CleanShot 2023-10-20 at 17 05 06

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit e637553
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6532fe7f3a345a00081b9ee9
😎 Deploy Preview https://deploy-preview-961--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 20, 2023
Copy link
Member

@Mishura4 Mishura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well change

color = int32_not_null(j, "color");
as well so it doesn't fill it to 0 even if the field is present

@Mishura4 Mishura4 added bug Something isn't working and removed documentation Improvements or additions to documentation labels Oct 20, 2023
@Mishura4 Mishura4 merged commit f9c55bf into brainboxdotcc:dev Oct 20, 2023
62 checks passed
@erics118 erics118 deleted the dev branch October 20, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code Improvements or additions to code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants