Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added roles to emojis #959

Merged
merged 7 commits into from
Oct 21, 2023
Merged

Conversation

Jaskowicz1
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 commented Oct 20, 2023

This PR adds roles to emojis, allowing bots to restrict emojis to certain roles. You can view discord's documentation about this at this page.

This also changes how we send information to discord, as we were sending too much information last time (dead data).

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit e3083ce
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6533960ded95cb00080e5b0f
😎 Deploy Preview https://deploy-preview-959--dpp-dev.netlify.app/classdpp_1_1emoji
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 20, 2023
@Jaskowicz1 Jaskowicz1 self-assigned this Oct 20, 2023
@Jaskowicz1 Jaskowicz1 added the breaking This pull request introduces breaking changes label Oct 20, 2023
@Jaskowicz1 Jaskowicz1 marked this pull request as ready for review October 20, 2023 15:29
@Jaskowicz1
Copy link
Contributor Author

image

Here's an image of it working! In this image, I restricted an emoji to my role only, meaning Brain couldn't use the emoji "memelol" until I set the roles variable to a blank array.

include/dpp/emoji.h Outdated Show resolved Hide resolved
@Jaskowicz1 Jaskowicz1 requested a review from Mishura4 October 21, 2023 09:12
@braindigitalis braindigitalis changed the title feat!: added roles to emojis feat: added roles to emojis Oct 21, 2023
@braindigitalis braindigitalis merged commit f19db87 into brainboxdotcc:dev Oct 21, 2023
34 checks passed
@Jaskowicz1 Jaskowicz1 removed the breaking This pull request introduces breaking changes label Oct 27, 2023
@Jaskowicz1 Jaskowicz1 deleted the emoji-fixes branch November 13, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants