Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: updated integration to now contain more information #954

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

Jaskowicz1
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 commented Oct 19, 2023

This PR updates integration according to this page in the documentation. This may also be a breaking change as I removed a deprecated feature, along with changing account_name and account_id to a struct.

This PR also severely changes the documentation for many variables in this, as it never stated before which variables would not appear for a bot. It also just missing documentation that discord was providing.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 34c5fe6
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6530ffe2cd94460009253962
😎 Deploy Preview https://deploy-preview-954--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 19, 2023
@Jaskowicz1 Jaskowicz1 self-assigned this Oct 19, 2023
@Jaskowicz1 Jaskowicz1 added enhancement New feature or request breaking This pull request introduces breaking changes and removed enhancement New feature or request labels Oct 19, 2023
@braindigitalis braindigitalis merged commit 7150796 into brainboxdotcc:dev Oct 19, 2023
35 checks passed
@Jaskowicz1 Jaskowicz1 deleted the changing-integration branch November 13, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This pull request introduces breaking changes code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants