Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow changing of HTTP protocol to 1.0 for backwards API endpoints and broken servers #951

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

braindigitalis
Copy link
Contributor

@braindigitalis braindigitalis commented Oct 17, 2023

Adds optional parameter to dpp::cluster::request(). This is a non-breaking change, the default is still 1.1. This is required for some braindead api's im working with in DPP, so if i'm having this problem others could too. This offers a workaround, which is there if others want to use it.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@braindigitalis braindigitalis self-assigned this Oct 17, 2023
@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 56b8320
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/652eda148857e40008ef6e96
😎 Deploy Preview https://deploy-preview-951--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@braindigitalis braindigitalis merged commit ee0b5f6 into dev Oct 17, 2023
59 of 60 checks passed
@braindigitalis braindigitalis deleted the set_http_protocol branch October 17, 2023 19:04
@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants