Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make modals work again by making to_json_impl and fill_from_json virtual #950

Merged
merged 2 commits into from
Oct 16, 2023
Merged

fix: make modals work again by making to_json_impl and fill_from_json virtual #950

merged 2 commits into from
Oct 16, 2023

Conversation

braindigitalis
Copy link
Contributor

@braindigitalis braindigitalis commented Oct 16, 2023 •
edited
Loading

these were not made virtual and need to be for modal dialogs to work

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@braindigitalis braindigitalis self-assigned this Oct 16, 2023
@netlify
Copy link

netlify bot commented Oct 16, 2023 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 94d1997
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/652da9034ec9f9000838eb71
😎 Deploy Preview https://deploy-preview-950--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jaskowicz1 Jaskowicz1 linked an issue Oct 16, 2023 that may be closed by this pull request
Modals are broken on latest dev #946
Closed
@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 16, 2023
@braindigitalis braindigitalis merged commit 6f45bec into dev Oct 16, 2023
48 of 49 checks passed
@braindigitalis braindigitalis deleted the fix_modals branch October 16, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaskowicz1 Jaskowicz1 Jaskowicz1 approved these changes

Assignees

@braindigitalis braindigitalis

Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modals are broken on latest dev
2 participants
@braindigitalis @Jaskowicz1