fix: dont require guild cache to fill member roles in message #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Jaskowicz1
requested changes
Oct 14, 2023
Jaskowicz1
approved these changes
Oct 14, 2023
Jaskowicz1
changed the title
Mishura4
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event all caches are disabled, roles list in the member for a message was empty. This was because it was internally using find_guild and skipping this part of the deserialisation. It does not need to do this. This fix ensures that if all caching is off, and we have the guild members intent, the guild member list in the messages member field will be popupated. I'm relying on this in the yeet bot.
Code change checklist