Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fix json_interface #937

Merged
merged 2 commits into from
Oct 11, 2023
Merged

refactor: fix json_interface #937

merged 2 commits into from
Oct 11, 2023

Conversation

Mishura4
Copy link
Member

@Mishura4 Mishura4 commented Oct 10, 2023 •
edited
Loading

“nobody could pass the unit tests when they thought they would "fix" the json interface” - brain, 2023
It has been done.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@netlify
Copy link

netlify bot commented Oct 10, 2023 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 55723df
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/65269db16c6d7d0008c2d793
😎 Deploy Preview https://deploy-preview-937--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 10, 2023
@Mishura4 Mishura4 added enhancement New feature or request and removed documentation Improvements or additions to documentation labels Oct 10, 2023
@Mishura4 Mishura4 force-pushed the json branch 4 times, most recently from ac81d8b to 1c5ac5c Compare October 10, 2023 18:06
@Mishura4 Mishura4 marked this pull request as ready for review October 11, 2023 15:31
@braindigitalis braindigitalis merged commit d232231 into brainboxdotcc:dev Oct 11, 2023
@Mishura4 Mishura4 deleted the json branch October 19, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braindigitalis braindigitalis braindigitalis approved these changes

Assignees
No one assigned
Labels
code Improvements or additions to code. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mishura4 @braindigitalis