Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: changed making_threads.md to include more info #932

Merged
merged 1 commit into from
Oct 9, 2023
Merged

docs: changed making_threads.md to include more info #932

merged 1 commit into from
Oct 9, 2023

Conversation

Jaskowicz1
Copy link
Contributor

This PR changes making_threads.md, adding a section on locking threads and changing the wording on the second example. This PR also renames the page.

The second example was reworded as, due to #930, it was no longer the only way to get a thread to talk in it. This meant that the example should be changed to show how you could loop through all of them, to keep the example. That meant adding a third example, showing how to use thread_get.

Documentation change checklist

  • My documentation changes follow the same style as the rest of the documentation and any examples follow the coding style guide.
  • I tested that my change works before raising the PR (via running doxygen, and testing examples).
  • I have not moved any existing pages or changed any existing URLs without strong justification as to why.
  • I have not generated content using AI or a desktop utility such as grammarly.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 9, 2023
@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 4becfcc
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6523e0d9f049790008d73d97
😎 Deploy Preview https://deploy-preview-932--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jaskowicz1 Jaskowicz1 marked this pull request as draft October 9, 2023 11:31
@Jaskowicz1
Copy link
Contributor Author

Converted to draft until #930 and #931 are merged and pushed to master.

@Jaskowicz1 Jaskowicz1 marked this pull request as ready for review October 9, 2023 12:44
@braindigitalis braindigitalis merged commit 2d11c8f into brainboxdotcc:dev Oct 9, 2023
29 checks passed
@Jaskowicz1 Jaskowicz1 deleted the threads-docs branch October 14, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants