Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improv: freshen up dpp::snowflake and dpp::managed #912

Merged
merged 13 commits into from
Oct 7, 2023
Merged

improv: freshen up dpp::snowflake and dpp::managed #912

merged 13 commits into from
Oct 7, 2023

Conversation

Mishura4
Copy link
Member

@Mishura4 Mishura4 commented Oct 2, 2023

This PR modernizes dpp::snowflake and dpp::managed a little bit, and makes them constexpr-compatible
API is unchanged

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@netlify
Copy link

netlify bot commented Oct 2, 2023 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 1c2f625
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/652036202a492600086afcbf
😎 Deploy Preview https://deploy-preview-912--dpp-dev.netlify.app/classdpp_1_1snowflake
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 2, 2023
@Mishura4 Mishura4 added enhancement New feature or request and removed documentation Improvements or additions to documentation labels Oct 2, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 2, 2023
@Mishura4 Mishura4 removed the documentation Improvements or additions to documentation label Oct 3, 2023
Mishura4
Mishura4 commented Oct 3, 2023
View reviewed changes
include/dpp/snowflake.h Outdated Show resolved Hide resolved
@Mishura4 Mishura4 marked this pull request as ready for review October 5, 2023 16:50
Jaskowicz1
Jaskowicz1 requested changes Oct 5, 2023
View reviewed changes
include/dpp/snowflake.h Outdated Show resolved Hide resolved
include/dpp/snowflake.h Outdated Show resolved Hide resolved
src/dpp/snowflake.cpp Show resolved Hide resolved
braindigitalis
braindigitalis requested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@braindigitalis braindigitalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

namespace doesnt need to be indented any more

@Mishura4
Copy link
Member Author

Mishura4 commented Oct 6, 2023

Updated

@braindigitalis braindigitalis merged commit af25a53 into brainboxdotcc:dev Oct 7, 2023
28 checks passed
@Mishura4 Mishura4 deleted the constructors branch October 19, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaskowicz1 Jaskowicz1 Jaskowicz1 approved these changes

@braindigitalis braindigitalis braindigitalis approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mishura4 @braindigitalis @Jaskowicz1