Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking, fix: guild_member state tracking #909

Merged
merged 13 commits into from
Oct 2, 2023

Conversation

braindigitalis
Copy link
Contributor

@braindigitalis braindigitalis commented Oct 2, 2023

  • breaking, fix: guild_member state tracking.
    You must now use add_role, remove_role or set_roles, also set_nickname on a guild_member for edit_guild_mebmer to have any effect on that value. This fixes longstanding issue where more permissions are required than should be, to edit guild members
  • test: move mutltiheader cookie test to extended, impossible to test in uk and eu due to GDPR

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

You must now use add_role, remove_role or set_roles, also set_nickname on a guild_member for edit_guild_mebmer to have any effect on that value.
This fixes longstanding issue where more permissions are required than should be, to edit guild members
@braindigitalis braindigitalis self-assigned this Oct 2, 2023
@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit e701ca8
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/651ada27b9dbc800085776b8
😎 Deploy Preview https://deploy-preview-909--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 2, 2023
@braindigitalis braindigitalis added bug Something isn't working build Issue or Pull Request related to the build process labels Oct 2, 2023
Copy link
Member

@Mishura4 Mishura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes + making the fields private as we discussed on Discord, and good for me

src/dpp/guild.cpp Outdated Show resolved Hide resolved
src/dpp/guild.cpp Outdated Show resolved Hide resolved
src/dpp/guild.cpp Outdated Show resolved Hide resolved
include/dpp/guild.h Show resolved Hide resolved
include/dpp/guild.h Outdated Show resolved Hide resolved
include/dpp/guild.h Outdated Show resolved Hide resolved
include/dpp/guild.h Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the build Issue or Pull Request related to the build process label Oct 2, 2023
src/dpp/role.cpp Outdated Show resolved Hide resolved
src/dpp/guild.cpp Outdated Show resolved Hide resolved
src/dpp/guild.cpp Outdated Show resolved Hide resolved
src/dpp/guild.cpp Outdated Show resolved Hide resolved
src/dpp/guild.cpp Outdated Show resolved Hide resolved
src/dpp/guild.cpp Outdated Show resolved Hide resolved
@braindigitalis braindigitalis added the build Issue or Pull Request related to the build process label Oct 2, 2023
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bellissimo.

Copy link
Member

@Mishura4 Mishura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toad doing a thumbs up motion

@github-actions github-actions bot removed the build Issue or Pull Request related to the build process label Oct 2, 2023
@braindigitalis braindigitalis merged commit 35159e2 into dev Oct 2, 2023
@braindigitalis braindigitalis deleted the only_send_partial_member branch October 2, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants