Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Improved security on workflows. #903

Merged
merged 4 commits into from
Oct 1, 2023
Merged

ci: Improved security on workflows. #903

merged 4 commits into from
Oct 1, 2023

Conversation

Jaskowicz1
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 commented Oct 1, 2023

This PR changes the security on the workflows to follow GitHub's security workflow for permissions. This PR does not change the following pages:

  • ci.yml (not enough information nor testing to see if this will work)
  • codeql.yml (permissions already exist here)
  • dependency-review.yml (permissions already exist here)
  • scorecard.yml (permissions already exist here)

Documentation change checklist

  • My documentation changes follow the same style as the rest of the documentation and any examples follow the coding style guide.
  • I tested that my change works before raising the PR (via running doxygen, and testing examples).
  • I have not moved any existing pages or changed any existing URLs without strong justification as to why.
  • I have not generated content using AI or a desktop utility such as grammarly.

@netlify
Copy link

netlify bot commented Oct 1, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 5fbe9fe
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/65195b762d245000097cceb5
😎 Deploy Preview https://deploy-preview-903--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jaskowicz1
Copy link
Contributor Author

Jaskowicz1 commented Oct 1, 2023

Removed documentation.yml from the PR description after discussions with Brain in the Discord server. Made a new push to add top-level permissions.

@Jaskowicz1 Jaskowicz1 added github_actions Pull requests that update GitHub Actions code and removed github_action labels Oct 1, 2023
@braindigitalis braindigitalis merged commit 0cb41f5 into brainboxdotcc:dev Oct 1, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants