Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added component default values #889

Merged
merged 7 commits into from
Oct 16, 2023

Conversation

Commandserver
Copy link
Member

@Commandserver Commandserver commented Sep 24, 2023

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@netlify
Copy link

netlify bot commented Sep 24, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 8574d29
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/652d646a0e2ce10008366943
😎 Deploy Preview https://deploy-preview-889--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 24, 2023
@Commandserver Commandserver added enhancement New feature or request and removed documentation Improvements or additions to documentation labels Sep 24, 2023
@Jaskowicz1
Copy link
Contributor

Wait, 4 commits from here are in #732 .
How has GitHub not picked up on this?

@braindigitalis
Copy link
Contributor

Wait, 4 commits from here are in #732 . How has GitHub not picked up on this?

It's just a difference in history between branches, it'll iron out in the merge

@Jaskowicz1
Copy link
Contributor

Wait, 4 commits from here are in #732 . How has GitHub not picked up on this?

It's just a difference in history between branches, it'll iron out in the merge

Ah right 👍

@Commandserver
Copy link
Member Author

Oopsy whoopsy

@braindigitalis
Copy link
Contributor

is this ready at all?

@Jaskowicz1 Jaskowicz1 added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 7, 2023
@Jaskowicz1 Jaskowicz1 changed the title feat: added message_author_id field to message_reaction_add_t event feat: added component default values Oct 14, 2023
@Jaskowicz1
Copy link
Contributor

I've renamed this PR from feat: added message_author_id field to message_reaction_add_t event to feat: added component default values. I'll also test this and see if this good to go 👍

src/dpp/message.cpp Outdated Show resolved Hide resolved
src/dpp/message.cpp Outdated Show resolved Hide resolved
@braindigitalis braindigitalis marked this pull request as ready for review October 16, 2023 16:27
@braindigitalis
Copy link
Contributor

i have ticked the boxes in the pr, and added archies changes to merge this, as i need it in my own projects.

@braindigitalis braindigitalis merged commit b37e9ac into brainboxdotcc:dev Oct 16, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants